Skip to content

fix(etl): enforce accepted status URL invariant - #273

Merged
github-actions[bot] merged 2 commits into
developfrom
fix/accepted-status-url-invariant-272
Aug 11, 2026
Merged

fix(etl): enforce accepted status URL invariant#273
github-actions[bot] merged 2 commits into
developfrom
fix/accepted-status-url-invariant-272

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Fixes #272.

Strict fail-first branch from exact protected develop@942d164ceb7af497bb28a95f842db96429d1bdc4.

Current test-only head 8caddd09147286792216fcce953e30cda690153e adds a dedicated production-boundary test class rather than touching EtlJobModelTest, which is owned by the active #271 writer. Protected source accepts blank, absolute, authority-bearing, and non-root-relative statusUrl values despite documenting an origin-relative monitor resource contract. Hosted RED must therefore be a focused assertion failure from EtlJobAcceptedResponseStatusUrlTest after normal compile/startup; dependency/setup/fixture failure is not valid RED.

After valid RED, the narrow GREEN may touch only EtlJobAcceptedResponse plus this focused test unless fresh evidence requires less. Preserve the valid /api/etl/jobs/{uuid} response, UUID/status semantics, controller location construction, durable-job persistence, active #271 lifecycle work, #121 stack, and canonical docs #149. Checks/reviews on the RED head or any predecessor do not transfer to a later implementation head.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d663b81c-e60b-4f23-8ad8-dffe4d51cc8a

📥 Commits

Reviewing files that changed from the base of the PR and between 942d164 and c8c577b.

📒 Files selected for processing (2)
  • etl-service/src/main/java/com/xtrmetl/etl/job/EtlJobAcceptedResponse.java
  • etl-service/src/test/java/com/xtrmetl/etl/job/EtlJobAcceptedResponseStatusUrlTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 11:21
@github-actions
github-actions Bot merged commit 8dbea18 into develop Aug 11, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API integrity] Enforce accepted durable-job status URL invariant

1 participant